Skip to content

Milestones/ms1 #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Jul 26, 2019
Merged

Milestones/ms1 #16

merged 16 commits into from
Jul 26, 2019

Conversation

melihaksoy
Copy link
Owner

@melihaksoy melihaksoy commented Jul 11, 2019

Closes #11
Closes #13
Closes #17
Closes #18
Closes #19
Closes #6
Closes #3
Closes #12
Closes #15

Worked on #14, but will skip. It's not suitable at this time.

@melihaksoy melihaksoy added this to the General fixes milestone Jul 11, 2019
@melihaksoy melihaksoy self-assigned this Jul 11, 2019
@codecov
Copy link

codecov bot commented Jul 23, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@0d75dc8). Click here to learn what that means.
The diff coverage is 26.26%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #16   +/-   ##
=========================================
  Coverage          ?   22.14%           
=========================================
  Files             ?       54           
  Lines             ?      447           
  Branches          ?       58           
=========================================
  Hits              ?       99           
  Misses            ?      330           
  Partials          ?       18
Impacted Files Coverage Δ
...tlin/com/melih/core/base/lifecycle/BaseFragment.kt 0% <ø> (ø)
.../main/kotlin/com/melih/list/ui/LaunchesActivity.kt 0% <ø> (ø)
...lin/com/melih/repository/entities/MissionEntity.kt 20% <ø> (ø)
...tlin/com/melih/repository/entities/LaunchEntity.kt 37.5% <ø> (ø)
...in/com/melih/repository/entities/LaunchesEntity.kt 33.33% <ø> (ø)
...n/kotlin/com/melih/core/utils/SnackbarBehaviour.kt 0% <ø> (ø)
...tlin/com/melih/repository/entities/RocketEntity.kt 50% <ø> (ø)
...tlin/com/melih/core/base/lifecycle/BaseActivity.kt 0% <ø> (ø)
.../kotlin/com/melih/list/di/modules/LaunchesBinds.kt 0% <ø> (ø)
...in/kotlin/com/melih/detail/di/DetailContributor.kt 0% <ø> (ø)
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d75dc8...7fdd2e1. Read the comment docs.

@melihaksoy melihaksoy changed the title WIP: Milestones/ms1 Milestones/ms1 Jul 26, 2019
@melihaksoy melihaksoy merged commit d60ae9e into master Jul 26, 2019
@melihaksoy melihaksoy deleted the milestones/ms1 branch July 26, 2019 11:38
melihaksoy added a commit that referenced this pull request Jul 26, 2019
* Closes #11

* Closes #13

* Closes #17

* Closes #18

* Closes #19

* Closes #6

* Closes #3

* Closes #12

* Closes #15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant