Fix for pkName and openapi specs #584
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
adnoh
commented
Oct 16, 2019
adnoh
commented
- if the pkName is not "id" it differs from /components/parameters. So as a workaround I would hardcode it (otherwise openapi validators are not happy)
- openapi specs require unique operationId field
…mponents/parameters" maybe more a workaround than a fix. Better way would be to fix components
mevdschee
requested changes
Oct 16, 2019
There was a problem hiding this comment.
Thank you very much for this great PR! It is almost ready to merge. A few points:
Changes should be done in the /src directory and not in the compiled api.php as they will be overwritten in a build.
If you feel that you did enough, then I will merge it as is and do the changes for you.
edit: I made the changes for you.
Regards, Maurits
|
v2.6.1 is released with these changes merged. Thank you very much for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.