Fix zip path traversal error and update to v3.0.6 (56) #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microbit-grace
changed the title
|
It's not going to happen, because the zip is internal to the app, but... What happens if the exception gets thrown? Does it get caught, or crash the app? Could we get away without throwing an exception, and just step over files with problem paths and continue copying the rest? |
I suppose it would crash the app. I have added a commit to continue instead 1778a85 |
|
Thanks @microbit-grace Hopefully that will get rid of the warning. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error found in pre-launch report.
"Your app contains an unsafe unzipping pattern that may lead to a Path Traversal vulnerability. Please see this Google Help Center article to learn how to fix the issue.
com.samsung.microbit.utils.ProjectsHelper.installSamples"
cc: @jaustin @microbit-matt-hillsdon