Partially remove unused camera-related code #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To remove security error for implicit internal intent
microbit-grace
commented
Apr 2, 2024
Comment on lines
-160
to
-163
| private static void recVideoStart() { | ||
| Intent intent = new Intent(ACTION_TAKE_VIDEO); | ||
| MBApp.getApp().sendBroadcast(intent); | ||
| } |
There was a problem hiding this comment.
Flagging part that the pre-launch report is unhappy about
microbit-grace
commented
Apr 2, 2024
Comment on lines
-152
to
-155
| private static void takePic() { | ||
| Intent intent = new Intent(ACTION_TAKE_PICTURE); | ||
| MBApp.getApp().sendBroadcast(intent); | ||
| } |
There was a problem hiding this comment.
Flagging part that the pre-launch report is unhappy about
microbit-grace
commented
Apr 2, 2024
Comment on lines
-176
to
-179
| private static void toggleCamera() { | ||
| Intent intent = new Intent(ACTION_TOGGLE_CAMERA); | ||
| MBApp.getApp().sendBroadcast(intent); | ||
| } |
There was a problem hiding this comment.
Flagging part that the pre-launch report is unhappy about
|
Thanks @microbit-grace |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only removes enough unused code to not trigger security error for implicit internal intent in pre-launch report.
Error reported by pre-launch report
Your app contains an Implicit Internal Intent vulnerability. Please see this Google Help Center article for details.
com.samsung.microbit.plugin.CameraPlugin.recVideoStart
com.samsung.microbit.plugin.CameraPlugin.takePic
com.samsung.microbit.plugin.CameraPlugin.toggleCamera