Docs updates. #72
Merged
Docs updates. #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scale docs are now duplicated due to overloads. This will result in a translation key change but hopefully we can restore any translations.
microbit-matt-hillsdon
added a commit
to microbit-foundation/python-editor-v3
that referenced
this pull request
Sep 27, 2022
|
@microbit-matt-hillsdon Looks good, however, the scale example that uses the accelerometer value should have from values of (-2000, 2000), otherwise we're providing an example that can create a negative value for volume? |
Agreed to change this to -2000, 2000 -> |
microbit-matt-hillsdon
added a commit
to microbit-foundation/python-editor-v3
that referenced
this pull request
Sep 27, 2022
https://github.com/microbit-foundation/micropython-microbit-v2/releases/tag/v2.1.0 https://github.com/bbcmicrobit/micropython/releases/tag/v1.1.0 Stubs changes from microbit-foundation/micropython-microbit-stubs#72 Co-authored-by: Robert Knight <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scale docs are now duplicated due to overloads. This will result in a translation key change but hopefully we can restore any translations. The first line of the docstring has changed but the parameter text is good.