Fix variance issue by using Mapping for log.add. #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it's worth keeping the translations in this repo, even though arguably they're a derived artifact, as it makes them easy to test and use for usecases outside of the Python Editor. So I think we should start committing the api.json file from Crowdin as we do translation updates so that we can always regenerate the translated stubs from the last known-good translations if we've made a non-translation-related change. I'll do a translation sync that takes that approach and then pick up this PR. |
microbit-matt-hillsdon
force-pushed
the
log-add-variance
branch
from
e80d893 to
faddccc
Compare
|
Rebased on #76 and used new script to regenerate translations. |
microbit-matt-hillsdon
added a commit
to microbit-foundation/python-editor-v3
that referenced
this pull request
Oct 12, 2022
microbit-matt-hillsdon
added a commit
to microbit-foundation/python-editor-v3
that referenced
this pull request
Oct 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests will fail due to translations. I'll have a think about how best to deal with this.