Skip to content

Upgrade MicroPython #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 6, 2022
Merged

Upgrade MicroPython #47

merged 2 commits into from
Sep 6, 2022

Conversation

microbit-matt-hillsdon
Copy link
Contributor

@microbit-matt-hillsdon microbit-matt-hillsdon commented Sep 6, 2022

I've skipped to latest master as it has changes that require source
level updates here that I expect to be in the 2.1 release.

  • Add new sound and power source files
  • Update conversions to use new HAL constants
  • Update sound expression HAL for function name change
  • Stub the power HAL for now (all void returns)
  • Update config to add power module

@netlify
Copy link

netlify bot commented Sep 6, 2022

Deploy Preview for distracted-dubinsky-fd8a42 ready!

Name Link
🔨 Latest commit 70c57d7
🔍 Latest deploy log https://app.netlify.com/sites/distracted-dubinsky-fd8a42/deploys/63172a82f2b14c000857251c
😎 Deploy Preview https://deploy-preview-47--distracted-dubinsky-fd8a42.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@microbit-matt-hillsdon microbit-matt-hillsdon changed the title First pass updates. Upgrade MicroPython Sep 6, 2022
@microbit-matt-hillsdon
Copy link
Contributor Author

microbit-matt-hillsdon commented Sep 6, 2022

We might need to port to the JS filesystem the behaviour change in main.c that clears the log whenever main.py is opened for writing.

We already clear the log on flash though, so I think this would just catch self-rewriting programs which might not be worth the effort. See microbit-foundation/micropython-microbit-v2@6ade36b for the change. I'll check in with Carlos on this.

@microbit-matt-hillsdon
Copy link
Contributor Author

microbit-matt-hillsdon commented Sep 6, 2022

@microbit-robert, as part of review please take a look at the diff:

microbit-foundation/micropython-microbit-v2@318595a...804c5fe

..and see if there's anything I've missed that requires an update here.

@microbit-matt-hillsdon microbit-matt-hillsdon marked this pull request as ready for review September 6, 2022 10:42
I've skipped to latest master as it has changes that require source
level updates here that I expect to be in the 2.1 release.

- Add new sound and power source files
- Update conversions to use new HAL constants
- Update sound expression HAL for function name change
- Stub the power HAL for now (all void returns)
- Update config to add power module
Copy link
Contributor

@microbit-robert microbit-robert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Filesystem change already noted in comments.

@microbit-matt-hillsdon
Copy link
Contributor Author

Raised #48 for the data log issue.

@microbit-matt-hillsdon microbit-matt-hillsdon merged commit 61ed74a into main Sep 6, 2022
@microbit-matt-hillsdon microbit-matt-hillsdon deleted the update-micropython branch September 6, 2022 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants