Skip to content

Fix heap leak on soft reset. #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 8, 2022
Merged

Fix heap leak on soft reset. #50

merged 1 commit into from
Sep 8, 2022

Conversation

microbit-matt-hillsdon
Copy link
Contributor

Previously flashing in a loop would run out of memory.

@netlify
Copy link

netlify bot commented Sep 8, 2022

Deploy Preview for distracted-dubinsky-fd8a42 ready!

Name Link
🔨 Latest commit 9636706
🔍 Latest deploy log https://app.netlify.com/sites/distracted-dubinsky-fd8a42/deploys/6319f606fa10e100099fcd90
😎 Deploy Preview https://deploy-preview-50--distracted-dubinsky-fd8a42.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@microbit-matt-hillsdon
Copy link
Contributor Author

microbit-matt-hillsdon commented Sep 8, 2022

I reproduced with:

      const doFlash = () => {
        simulator.postMessage(
                {
                  kind: "flash",
                  filesystem: {
                    "main.py": new TextEncoder().encode(program.value),
                  },
                },
                "*"
              );
        setTimeout(doFlash, 50);
      }
      doFlash();

...at the end of the JS in demo.html.

Copy link
Contributor

@microbit-robert microbit-robert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@microbit-matt-hillsdon microbit-matt-hillsdon merged commit d7a68ab into main Sep 8, 2022
@microbit-matt-hillsdon microbit-matt-hillsdon deleted the heap-leak branch September 8, 2022 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants