Restart the WASM module when stopping/starting/panicking #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for distracted-dubinsky-fd8a42 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
microbit-matt-hillsdon
changed the title
Fixes panic HAL calls so the device is no longer operable afterwards. - Use the same logic for a normal stop/start. - Cache the WASM to avoid downloading and compiling it for each module instantiation. - Prefer using the _foo functions on the module vs cwrap. - Incidental fix to the radio message handling in demo.html
microbit-matt-hillsdon
force-pushed
the
modularize
branch
from
16fe288 to
0fd3b74
Compare
|
I still need to try this on Safari before merge. |
All good in Safari. |
Merged
microbit-robert
requested changes
Sep 9, 2022
Co-authored-by: Robert Knight <[email protected]>
Thanks, will test the level detection with that change in and then merge. |
We already precompile the WASM.
…on-microbit-v2-simulator into modularize
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes panic HAL calls so the device is no longer operable afterwards.
instantiation.
No editor changes needed, but given the level of change I've set up a review branch via the editor in case there are integration issues: https://review-python-editor-next.microbit.org/mod-sim-test/