Skip to content

Update active button and pin logo colours #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 14, 2022
Merged

Conversation

microbit-robert
Copy link
Contributor

No description provided.

@netlify
Copy link

netlify bot commented Sep 14, 2022

Deploy Preview for distracted-dubinsky-fd8a42 ready!

Name Link
🔨 Latest commit a1ae9af
🔍 Latest deploy log https://app.netlify.com/sites/distracted-dubinsky-fd8a42/deploys/6321cb12c8520400081e3dfe
😎 Deploy Preview https://deploy-preview-61--distracted-dubinsky-fd8a42.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@microbit-robert
Copy link
Contributor Author

Uses the same colours as MakeCode and the inverse fill of the pin logo. Doesn't look great here as we don't have the added stroke that MakeCode add on hovering a clickable element.

@microbit-robert microbit-robert marked this pull request as ready for review September 14, 2022 12:42
@microbit-matt-hillsdon
Copy link
Contributor

Uses the same colours as MakeCode and the inverse fill of the pin logo. Doesn't look great here as we don't have the added stroke that MakeCode add on hovering a clickable element.

We backed away from this as, in discussion with Giles, we don't think the non-copper area should highlight. We've also changed the colour to allow us to use the same colour in both places with improved contrast.

@microbit-matt-hillsdon
Copy link
Contributor

There's some loss of a subtle 3d effect on the buttons, but it's not one we were maintaining through the interaction (i.e. it doesn't depress) so I think it's better gone.

@microbit-matt-hillsdon microbit-matt-hillsdon merged commit c70d15d into main Sep 14, 2022
@microbit-matt-hillsdon microbit-matt-hillsdon deleted the button-color branch September 14, 2022 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants