Skip to content

Sandbox the iframe. #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 14, 2022
Merged

Sandbox the iframe. #64

merged 1 commit into from
Sep 14, 2022

Conversation

microbit-matt-hillsdon
Copy link
Contributor

@microbit-matt-hillsdon microbit-matt-hillsdon commented Sep 14, 2022

This isn't particularly effective with the demo that loads the local simulator as it's the same origin but useful for copy/paste of this code with a real deployment URL.

See microbit-foundation/python-editor-v3#959 for the Python Editor V3 equivalent which is a bit more of a meaningful scenario.

This isn't particularly effective with the demo that loads the local
simulator as it's the same origin but useful for copy/paste of this code
with a real deployment URL.
@netlify
Copy link

netlify bot commented Sep 14, 2022

Deploy Preview for distracted-dubinsky-fd8a42 ready!

Name Link
🔨 Latest commit 81fb703
🔍 Latest deploy log https://app.netlify.com/sites/distracted-dubinsky-fd8a42/deploys/6321db8eb9c21f00097b5c8a
😎 Deploy Preview https://deploy-preview-64--distracted-dubinsky-fd8a42.netlify.app/demo
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@microbit-robert microbit-robert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@microbit-matt-hillsdon microbit-matt-hillsdon merged commit 67006d2 into main Sep 14, 2022
@microbit-matt-hillsdon microbit-matt-hillsdon deleted the iframe-sandbox branch September 14, 2022 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants