Skip to content

Glue our translations to the simulator. #925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Sep 1, 2022

Conversation

microbit-matt-hillsdon
Copy link
Collaborator

@microbit-matt-hillsdon microbit-matt-hillsdon commented Sep 1, 2022

It doesn't need much text so no need for it to have a translation
mechanism of its own. Could revisit if there's third-party demand - if we had translations at that point we could just inline them.

It doesn't need much text so no need for it to have a translation
mechanism of its own. Could revisit if there's third-party demand
- if we had translations at that point we could just inline them.
@github-actions
Copy link

github-actions bot commented Sep 1, 2022

Copy link
Collaborator

@microbit-robert microbit-robert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now.

@microbit-matt-hillsdon microbit-matt-hillsdon merged commit e3b054b into main Sep 1, 2022
@microbit-matt-hillsdon microbit-matt-hillsdon deleted the sim-iframe-translate branch September 1, 2022 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants