Skip to content

Check UI string variables match. #958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 13, 2022
Merged

Conversation

microbit-matt-hillsdon
Copy link
Collaborator

Would have caught #956 No additional errors.
I've also manually reviewed the ICU plural strings, and while a surprising number don't seem to be translated there are no structural errors.

Would have caught #956
No additional errors.
I've also manually reviewed the ICU plural strings, and while a surprising
number don't seem to be translated there are no structural errors.
@github-actions
Copy link

Copy link
Collaborator

@microbit-robert microbit-robert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@microbit-matt-hillsdon microbit-matt-hillsdon merged commit b0912ed into main Sep 13, 2022
@microbit-matt-hillsdon microbit-matt-hillsdon deleted the check-ui-variables branch September 13, 2022 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants