Skip to content

Rename python-editor-next to python-editor-v3 #967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 16, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ _steps:
install_dependencies: &install_dependencies
run: npm ci --cache .npm-cache && sudo npm config set @microbit-foundation:registry https://npm.pkg.github.com/microbit-foundation && sudo npm i -g @microbit-foundation/[email protected] @microbit-foundation/[email protected] @microbit-foundation/circleci-npm-package-versioner@1
install_theme: &install_theme
run: npm config set @microbit-foundation:registry https://npm.pkg.github.com/microbit-foundation && npm install --no-save @microbit-foundation/python-editor-next[email protected].180
run: npm config set @microbit-foundation:registry https://npm.pkg.github.com/microbit-foundation && npm install --no-save @microbit-foundation/python-editor-v3[email protected].183
update_version: &update_version
run: npm run ci:update-version
build: &build
Expand Down
3 changes: 0 additions & 3 deletions .devcontainer/Dockerfile

This file was deleted.

19 changes: 0 additions & 19 deletions .devcontainer/devcontainer.json

This file was deleted.

2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ possible through contributions of companies and individuals around the world.
This project is managed on GitHub, and the best way to contribute is to jump in
and fix/file issues.

https://github.com/microbit-foundation/python-editor-next
https://github.com/microbit-foundation/python-editor-v3

Significant features are best discussed first to make sure everyone is agreed
on the best direction.
Expand Down
6 changes: 1 addition & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,9 @@ CodeMirror 6 has [great documentation](https://codemirror.net/6/docs/). The [sys

The project was bootstrapped with [Create React App](https://github.com/facebook/create-react-app). You can learn more in the [Create React App documentation](https://facebook.github.io/create-react-app/docs/getting-started).

If you use Visual Studio Code you might find the devcontainer included in this repository a useful option to get an automatically configured development environment. [Find out more about containers and Visual Studio Code](https://code.visualstudio.com/docs/remote/containers).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll happily reinstate and update this dev container if anyone gets in touch to say they use it. Removing it for now as, so far as we know, it's unused by folks working on this project and therefore untested/unmaintained.


## Deployments

The editor is deployed by [CircleCI](https://circleci.com/gh/microbit-foundation/python-editor-next).
The editor is deployed by [CircleCI](https://circleci.com/gh/microbit-foundation/python-editor-v3).

The `main` branch is deployed to https://stage-python-editor-next.microbit.org/ on each commit.

Expand All @@ -46,8 +44,6 @@ For custom deployments, note that the educational content in the sidebar is curr
3. Install the dependencies via `npm install`.
4. Choose from the NPM scripts documented below.

If you're using the devcontainer with Visual Studio Code then the "Clone a repository from GitHub in a Container Volume" action will address steps 1 through 3.

### `npm start`

Runs the app in the development mode.\
Expand Down
2 changes: 1 addition & 1 deletion craco.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ const path = require("path");
const fs = require("fs");

// Support optionally pulling in external branding if the module is installed.
const theme = "@microbit-foundation/python-editor-next-microbit";
const theme = "@microbit-foundation/python-editor-v3-microbit";
const external = `node_modules/${theme}`;
const internal = "src/deployment/default";

Expand Down
2 changes: 1 addition & 1 deletion src/App.css
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
}

:root {
/* Seems to fix a Safari glitch: https://github.com/microbit-foundation/python-editor-next/issues/369 */
/* Seems to fix a Safari glitch: https://github.com/microbit-foundation/python-editor-v3/issues/369 */
font-size: 16px;
}

Expand Down
4 changes: 2 additions & 2 deletions src/device/webusb.ts
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ export class MicrobitWebUSBConnection
// If serial is in progress when the page unloads with V1 DAPLink 0254 or V2 0255
// then it'll fail to reconnect with mismatched command/response errors.
// Try hard to disconnect as a workaround.
// https://github.com/microbit-foundation/python-editor-next/issues/89
// https://github.com/microbit-foundation/python-editor-v3/issues/89
this.unloading = true;
this.stopSerialInternal();
// The user might stay on the page if they have unsaved changes and there's another beforeunload listener.
Expand Down Expand Up @@ -343,7 +343,7 @@ export class MicrobitWebUSBConnection
return this.withEnrichedErrors(async () => {
if (this.connection) {
// Using WebUSB/DAPJs we're limited to 64 byte packet size with a two byte header.
// https://github.com/microbit-foundation/python-editor-next/issues/215
// https://github.com/microbit-foundation/python-editor-v3/issues/215
const maxSerialWrite = 62;
let start = 0;
while (start < data.length) {
Expand Down
2 changes: 1 addition & 1 deletion src/e2e/app.ts
Original file line number Diff line number Diff line change
Expand Up @@ -493,7 +493,7 @@ export class App {
const content = await this.focusEditorContent();
// The short delay seems to improve reliability triggering autocomplete.
// Previously finding autocomplete options failed approx 1 in 30 times.
// https://github.com/microbit-foundation/python-editor-next/issues/419
// https://github.com/microbit-foundation/python-editor-v3/issues/419
return content.type(text, { delay: 10 });
}

Expand Down
2 changes: 1 addition & 1 deletion src/editor/codemirror/CodeMirrorView.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ const CodeMirrorView = ({ value, ...props }: CodeMirrorViewProps) => {
".cm-scroller": {
// Reduced from 1.4 to a value that gets integral line height on Safari with the 16px
// font size used in Reference to sidestep https://bugs.webkit.org/show_bug.cgi?id=225695
// See https://github.com/microbit-foundation/python-editor-next/issues/369
// See https://github.com/microbit-foundation/python-editor-v3/issues/369
lineHeight: 1.375,
},
}),
Expand Down
2 changes: 1 addition & 1 deletion src/editor/codemirror/language-server/docstrings.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ export interface DocSectionsSplit {
}

export const splitDocString = (markup: string): DocSectionsSplit => {
// Workaround for https://github.com/microbit-foundation/python-editor-next/issues/501
// Workaround for https://github.com/microbit-foundation/python-editor-v3/issues/501
if (markup.startsWith("\\\n")) {
markup = markup.substring(2);
}
Expand Down
2 changes: 1 addition & 1 deletion src/editor/codemirror/language-server/view.ts
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ class LanguageServerView extends BaseLanguageServerView implements PluginValue {
update({ docChanged }: ViewUpdate) {
if (docChanged) {
// We should do incremental updates here
// See https://github.com/microbit-foundation/python-editor-next/issues/256
// See https://github.com/microbit-foundation/python-editor-v3/issues/256
this.client.didChangeTextDocument(this.uri, [
{ text: this.view.state.doc.toString() },
]);
Expand Down
2 changes: 1 addition & 1 deletion src/fs/storage.ts
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ export class SessionStorageFSStorage implements FSStorage {
return window.sessionStorage;
} catch (e) {
// We see SecurityError here in some scenarios
// https://github.com/microbit-foundation/python-editor-next/issues/736
// https://github.com/microbit-foundation/python-editor-v3/issues/736
return undefined;
}
};
Expand Down
4 changes: 2 additions & 2 deletions src/project/project-actions.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -527,7 +527,7 @@ export class ProjectActions {
if (e instanceof HexGenerationError) {
this.actionFeedback.expectedError({
title: this.intl.formatMessage({ id: "failed-to-build-hex" }),
// Not translated, see https://github.com/microbit-foundation/python-editor-next/issues/159
// Not translated, see https://github.com/microbit-foundation/python-editor-v3/issues/159
description: e.message,
});
} else {
Expand Down Expand Up @@ -555,7 +555,7 @@ export class ProjectActions {
} catch (e: any) {
this.actionFeedback.expectedError({
title: this.intl.formatMessage({ id: "failed-to-build-hex" }),
// Not translated, see https://github.com/microbit-foundation/python-editor-next/issues/159
// Not translated, see https://github.com/microbit-foundation/python-editor-v3/issues/159
description: e.message,
});
return;
Expand Down
4 changes: 2 additions & 2 deletions src/workbench/AboutDialog/AboutDialog.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ const versionInfo = [
{
name: "Editor",
value: process.env.REACT_APP_VERSION,
href: "https://github.com/microbit-foundation/python-editor-next",
href: "https://github.com/microbit-foundation/python-editor-v3",
},
...microPythonConfig.versions.map((mpy) => ({
name: mpy.name,
Expand Down Expand Up @@ -118,7 +118,7 @@ const AboutDialog = ({ isOpen, onClose }: AboutDialogProps) => {
rel="noopener noreferrer"
target="blank"
color="brand.500"
href="https://github.com/microbit-foundation/python-editor-next/graphs/contributors"
href="https://github.com/microbit-foundation/python-editor-v3/graphs/contributors"
>
{chunks}
</Link>
Expand Down