-
Notifications
You must be signed in to change notification settings - Fork 39
Rationalise URLs #970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rationalise URLs #970
Conversation
The mechanism could be simplified quite a bit but trying to keep change isolated to the router for now.
Preview build will be at |
Something evidently removes the trailing slash we add to PUBLIC_URL.
6cb6499
to
6d23691
Compare
Discussed having /reference/display/scroll and similarly for API. Ideally we'd decorate the data so that each reference topic and API entry knew its full slug and then keep the navigation logic largely the same. |
I gave this some thought. This is a lot of change for a relatively minor benefit. I think we'd change the CMS model if we considered this goal up front. The slugs as used are unique, just not qualified by module (for Reference) and I think they'll be OK in practice. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
The previous scheme assumed that we'd maintain independent state for the tabs, but we decided against that.
Therefore we can go for a more traditional URL routing scheme.
It could do with some simplification but, if we can fix the animation issue then exposing these URLs would be a step forward.