Skip to content

Rationalise URLs #970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Sep 20, 2022
Merged

Rationalise URLs #970

merged 10 commits into from
Sep 20, 2022

Conversation

microbit-matt-hillsdon
Copy link
Collaborator

@microbit-matt-hillsdon microbit-matt-hillsdon commented Sep 19, 2022

The previous scheme assumed that we'd maintain independent state for the tabs, but we decided against that.
Therefore we can go for a more traditional URL routing scheme.
It could do with some simplification but, if we can fix the animation issue then exposing these URLs would be a step forward.

The mechanism could be simplified quite a bit but trying to keep change
isolated to the router for now.
@github-actions
Copy link

Preview build will be at
https://review-python-editor-next.microbit.org/url-tidy/

@microbit-matt-hillsdon microbit-matt-hillsdon changed the title Url tidy Rationalise URLs Sep 19, 2022
Something evidently removes the trailing slash we add to PUBLIC_URL.
@microbit-matt-hillsdon
Copy link
Collaborator Author

Discussed having /reference/display/scroll and similarly for API.

Ideally we'd decorate the data so that each reference topic and API entry knew its full slug and then keep the navigation logic largely the same.

@microbit-matt-hillsdon
Copy link
Collaborator Author

microbit-matt-hillsdon commented Sep 20, 2022

Discussed having /reference/display/scroll and similarly for API.

Ideally we'd decorate the data so that each reference topic and API entry knew its full slug and then keep the navigation logic largely the same.

I gave this some thought. This is a lot of change for a relatively minor benefit. I think we'd change the CMS model if we considered this goal up front. The slugs as used are unique, just not qualified by module (for Reference) and I think they'll be OK in practice.

Copy link
Collaborator

@microbit-robert microbit-robert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@microbit-matt-hillsdon microbit-matt-hillsdon merged commit 58cd675 into main Sep 20, 2022
@microbit-matt-hillsdon microbit-matt-hillsdon deleted the url-tidy branch September 20, 2022 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants