Skip to content

Add compliance component. #975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 21, 2022
Merged

Add compliance component. #975

merged 7 commits into from
Sep 21, 2022

Conversation

microbit-robert
Copy link
Collaborator

No description provided.

@github-actions
Copy link

github-actions bot commented Sep 20, 2022

@microbit-robert
Copy link
Collaborator Author

Do not merge until deployment has been changed to avoid duplicate notices.

@microbit-robert
Copy link
Collaborator Author

Requires theme package update once https://github.com/microbit-foundation/python-editor-v3-microbit/pull/28 has been merged.

@microbit-robert microbit-robert marked this pull request as ready for review September 20, 2022 15:36
Copy link
Collaborator

@microbit-matt-hillsdon microbit-matt-hillsdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I tried locally with an iframe embed.
I'll defer merging this until first thing tomorrow in case of unexpected impact.

@microbit-matt-hillsdon microbit-matt-hillsdon merged commit 770946b into main Sep 21, 2022
@microbit-matt-hillsdon microbit-matt-hillsdon deleted the compliance branch September 21, 2022 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants