Skip to content

Deployment updates #986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 21, 2022
Merged

Deployment updates #986

merged 2 commits into from
Sep 21, 2022

Conversation

microbit-matt-hillsdon
Copy link
Collaborator

@microbit-matt-hillsdon microbit-matt-hillsdon commented Sep 21, 2022

Plan:

  • Check review branch deploy.
  • Update review CF and DNS.
  • Remove redundant environment variables from CircleCI
  • Merge this PR (not much choice to check staging properly)
  • Check staging deploy
  • Update staging versioner beta
  • Tag a pre-release
  • Check release deploy
  • Try /v/3/ on staging versioner
  • /v/beta on live versioner, replacing current beta
  • Use /v/beta in micro:bit classroom
    • Done but not released, one to discuss on Monday
  • Add notes to the clean-up task

All done except for the classroom release which is tracked elsewhere.

This updates deployment locations to remove the -next suffix and prep
for the V3 release.
@github-actions
Copy link

Preview build will be at
https://review-python-editor-next.microbit.org/deployment/

@microbit-matt-hillsdon microbit-matt-hillsdon merged commit ad32bac into main Sep 21, 2022
@microbit-matt-hillsdon microbit-matt-hillsdon deleted the deployment branch September 21, 2022 21:09
@microbit-matt-hillsdon
Copy link
Collaborator Author

microbit-matt-hillsdon commented Sep 21, 2022

Review deployments are working at https://review-python-editor-v3.microbit.org/deployment/

Remaining review actions:

  • The GH action that puts the link on PRs needs updating.
  • The old CNAME can be removed from the CF distribution
  • The old review content has been copied over but needs its acl prodding to make it visible
  • The old bucket can then be deleted

@microbit-matt-hillsdon
Copy link
Collaborator Author

The staging deployment isn't quite right. It's deployed to the correct path but with PUBLIC_URL unset. This is because it's only called for the review stage. Follow-up PR here: #987

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant