Use optional chaining to prevent button reference error. #997
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview build will be at |
|
We can definitely merge this, but perhaps we shouldn't disable the button at all? E.g. a quick enter, tab is quite confusing. I'm assuming disabling the button is what's preventing focus staying on it. Feels like it needs some kind of reaction though. |
microbit-matt-hillsdon
approved these changes
Sep 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a logged bug that appears to occur after sending a gesture to the simulator and then expand/collapsing the accelerometer module panel. This causes a re-render and the gesture button ref can be undefined. We should also not change the focus if the user's last action was to expand/collapse the module, so this seems a reasonable fix.