micropython/aiorepl: Use blocking reads for raw_repl. #1005
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dpgeorge I tested this with just raw paste in blocking, reverting the rest of raw repl to async. On an application with active log messages (~1 per second) |
dpgeorge
reviewed
Jun 3, 2025
micropython/aiorepl/aiorepl.py
Outdated
| @@ -161,7 +161,7 @@ async def task(g=None, prompt="--> "): | |||
| cmd = cmd[:-1] | |||
| sys.stdout.write("\x08 \x08") | |||
| elif c == CHAR_CTRL_A: | |||
| await raw_repl(s, g) | |||
| await raw_repl(g) | |||
There was a problem hiding this comment.
Leave s as an argument, but pass in sys.stdin.
andrewleech
force-pushed
the
aiorepl_raw_blocking
branch
from
2c01807 to
f5ee51e
Compare
dpgeorge
reviewed
Jun 3, 2025
andrewleech
force-pushed
the
aiorepl_raw_blocking
branch
from
f5ee51e to
bc5bb9f
Compare
dpgeorge
approved these changes
Jun 3, 2025
Raw REPL mode is generally used as a command channel where all stdio traffic is related directly to the raw commands and responses sent. For this to work in aiorepl we need to ensure background tasks don't sent/ receive anything on stdio else the command channel will be corrupted. The simplest way to achieve this is to make the raw commands blocking and atomic rather than asyncio, assuming the user wont leave the device in raw mode for too long at any one time. Signed-off-by: Andrew Leech <[email protected]>
dpgeorge
force-pushed
the
aiorepl_raw_blocking
branch
from
bc5bb9f to
aad2e48
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
raw repl mode is generally used as a command channel where all stdio traffic is related directly to the raw commands and responses sent.
For this to work in aiorepl we need to ensure background tasks don't sent/receive anything on stdio else the command channel will be corrupted.
The simplest way to achieve this is to make the raw commands blocking rather than asyncio, assuming the user wont leave the device in raw mode for too long at any one time.