Skip to content

Add HTMLTemplateDocument #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 1, 2015
Merged

Add HTMLTemplateDocument #22

merged 1 commit into from
Dec 1, 2015

Conversation

emilgpa
Copy link
Contributor

@emilgpa emilgpa commented Nov 11, 2015

@mhegazy
Copy link
Contributor

mhegazy commented Dec 1, 2015

👍

@mhegazy
Copy link
Contributor

mhegazy commented Dec 1, 2015

@zhengbli can we get this in?

@zhengbli
Copy link
Contributor

zhengbli commented Dec 1, 2015

@mhegazy We can for now, but I found that many of the similar interfaces (HTMLxxxElement) doesn't actually have a legal constructor, while my script generates constructors for them because at the time I thought it would be consistent with the old version (before the script) and reduce breaking changes. Although I think we probably should remove them all together at some point.

@mhegazy
Copy link
Contributor

mhegazy commented Dec 1, 2015

if we remove the constructors we break instanceof checks. so we need another solution here.

@zhengbli
Copy link
Contributor

zhengbli commented Dec 1, 2015

In that case we can take this change now which solves this particular issue, and then figure out how to deal with the constructors systematically later.

zhengbli added a commit that referenced this pull request Dec 1, 2015
Add HTMLTemplateDocument
@zhengbli zhengbli merged commit 3e90e86 into microsoft:master Dec 1, 2015
@zhengbli
Copy link
Contributor

zhengbli commented Dec 1, 2015

@DasHaus Thansk for your contribution :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants