Skip to content

Added correct definition for createIndex method of IDBObjectStore #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 4, 2015

Conversation

aksharpatel47
Copy link
Contributor

@msftclas
Copy link

msftclas commented Dec 3, 2015

Hi @aksharpatel47, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@msftclas
Copy link

msftclas commented Dec 3, 2015

@aksharpatel47, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, MSBOT;

@mhegazy
Copy link
Contributor

mhegazy commented Dec 3, 2015

👍

"name": "createIndex",
"signatures": ["createIndex(name: string, keyPath: string | string[], optionalParameters?: any): IDBIndex"]
},
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

niche: the indentation seems inconsistent. Use spaces instead of tabs.

@zhengbli
Copy link
Contributor

zhengbli commented Dec 3, 2015

Other than the comment, looks good to me 👍. Thanks for contributing @aksharpatel47 !

@aksharpatel47
Copy link
Contributor Author

@zhengbli There are a lot of other IndexedDB definitions missing such as multiEntry property of an Index, interfaces for options when creating an object store and an index. I can add them, but should I create a new issue and a pull request or add them here?

@zhengbli
Copy link
Contributor

zhengbli commented Dec 4, 2015

@aksharpatel47 An issue should be created for future references, the missing types can all belong to a single issue to avoid too much efforts. Some of them may be corrected next time we take an updated XML spec files from the Edge team, but it would be great if we can get a quick fix before that (which might be a painful process with many breaking changes). Thanks!

zhengbli added a commit that referenced this pull request Dec 4, 2015
Added correct definition for createIndex method of IDBObjectStore
@zhengbli zhengbli merged commit 722da4f into microsoft:master Dec 4, 2015
@aksharpatel47 aksharpatel47 deleted the IDBObjectStore_createIndex branch December 4, 2015 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants