-
Notifications
You must be signed in to change notification settings - Fork 443
Added correct definition for createIndex method of IDBObjectStore #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added correct definition for createIndex method of IDBObjectStore #27
Conversation
Hi @aksharpatel47, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! TTYL, MSBOT; |
@aksharpatel47, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR. |
👍 |
"name": "createIndex", | ||
"signatures": ["createIndex(name: string, keyPath: string | string[], optionalParameters?: any): IDBIndex"] | ||
}, | ||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
niche: the indentation seems inconsistent. Use spaces instead of tabs.
Other than the comment, looks good to me 👍. Thanks for contributing @aksharpatel47 ! |
@zhengbli There are a lot of other IndexedDB definitions missing such as multiEntry property of an Index, interfaces for options when creating an object store and an index. I can add them, but should I create a new issue and a pull request or add them here? |
@aksharpatel47 An issue should be created for future references, the missing types can all belong to a single issue to avoid too much efforts. Some of them may be corrected next time we take an updated XML spec files from the Edge team, but it would be great if we can get a quick fix before that (which might be a painful process with many breaking changes). Thanks! |
Added correct definition for createIndex method of IDBObjectStore
Fixes microsoft/TypeScript#5832