Skip to content

Mark Element.setAttribute's parameters as required #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 9, 2015
Merged

Mark Element.setAttribute's parameters as required #29

merged 1 commit into from
Dec 9, 2015

Conversation

LPGhatguy
Copy link
Contributor

This fixes microsoft/TypeScript#4407, which was reported as being an error on HTMLElement. The actual error was with Element.

@msftclas
Copy link

msftclas commented Dec 9, 2015

Hi @LPGhatguy, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@msftclas
Copy link

msftclas commented Dec 9, 2015

@LPGhatguy, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, MSBOT;

@zhengbli
Copy link
Contributor

zhengbli commented Dec 9, 2015

👍 LGTM. Thanks @LPGhatguy !

zhengbli added a commit that referenced this pull request Dec 9, 2015
Mark Element.setAttribute's parameters as required
@zhengbli zhengbli merged commit 1be2315 into microsoft:master Dec 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTMLElement.setAttribute's parameters are marked optional; they are not
3 participants