Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the type definitions for Streams:
ReadableStreamReadResult
with the newIteratorResult
definition from TypeScript 3.6. It is now equivalent toIteratorResult<T, T | undefined>
, but since the DOM types cannot depend ones2015.iterable
, I needed to add my owntypedef
with a union type. Fortunately, TypeScript will recognize these as equivalent thanks to its structural type system. 😄 Since this is a generic type alias, I have updated the emitter to support type parameters fortypedef
s.TextEncoderStream
andTextDecoderStream
from the Encoding standard. Theirreadable
andwritable
properties were defined as justReadableStream
andWritableStream
, so they had the default chunk typeany
. Now, we use the precise chunk types from the spec.I've also done some cleanup on how the Streams types are defined:
[NoInterfaceObject]
in (manually authored) WebIDL, instead of adding"no-interface-object"
to the overrides."override-exposed"
where the exposure was already correctly defined in the WebIDL.