Skip to content

fix(dom): intersect defaultView with globalThis #820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 17, 2020
Merged

fix(dom): intersect defaultView with globalThis #820

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion baselines/dom.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4607,7 +4607,7 @@ interface Document extends Node, DocumentAndElementEventHandlers, DocumentOrShad
* Returns null if the Document is not currently executing a script or SVG script element (e.g., because the running script is an event handler, or a timeout), or if the currently executing script or SVG script element represents a module script.
*/
readonly currentScript: HTMLOrSVGScriptElement | null;
readonly defaultView: WindowProxy | null;
readonly defaultView: (WindowProxy & typeof globalThis) | null;
/**
* Sets or gets a value that indicates whether the document can be edited.
*/
Expand Down
4 changes: 4 additions & 0 deletions inputfiles/overridingTypes.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -596,6 +596,10 @@
},
"properties": {
"property": {
"defaultView": {
"name": "defaultView",
"override-type": "(WindowProxy & typeof globalThis) | null"
},
"documentElement": {
"name": "documentElement",
"override-type": "HTMLElement",
Expand Down