Install playwright on demand (#40722)

andrewbranch · orta · web-flow · commit 2084404b8ffb · 2020-09-29T12:22:04.000-07:00
* Remove playwright from package.json

* Install playwright on demand

* Adds debugging info to the playwright script

* Move installation first

* Get it working on node 10 again

* Update browserIntegrationTest.js

* Update browserIntegrationTest.js

Co-authored-by: Orta &lt;git@orta.io&gt;
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -42,6 +42,9 @@ jobs:
     - name: Linter
       run:  npm run lint:ci
 
+    - name: Adding playwright
+      run: npm install --no-save --no-package-lock playwright
+
     - name: Validate the browser can import TypeScript
       run: gulp test-browser-integration
 
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -88,7 +88,6 @@
         "mocha-fivemat-progress-reporter": "latest",
         "ms": "latest",
         "node-fetch": "^2.6.0",
-        "playwright": "0.12.1",
         "plugin-error": "latest",
         "pretty-hrtime": "^1.0.3",
         "prex": "^0.4.3",
diff --git a/scripts/browserIntegrationTest.js b/scripts/browserIntegrationTest.js
@@ -1,14 +1,24 @@
-const playwright = require("playwright");
+// @ts-check
 const chalk = require("chalk");
 const { join } = require("path");
 const { readFileSync } = require("fs");
+try {
+    // eslint-disable-next-line import/no-extraneous-dependencies
+    require("playwright");
+}
+catch (error) {
+    throw new Error("Playwright is expected to be installed manually before running this script");
+}
+
+// eslint-disable-next-line import/no-extraneous-dependencies
+const playwright = require("playwright");
 
 // Turning this on will leave the Chromium browser open, giving you the
 // chance to open up the web inspector.
 const debugging = false;
 
 (async () => {
-  for (const browserType of ["chromium", "firefox", "webkit"]) {
+  for (const browserType of ["chromium", "firefox"]) {
     const browser = await playwright[browserType].launch({ headless: !debugging });
     const context = await browser.newContext();
     const page = await context.newPage();
@@ -21,7 +31,6 @@ const debugging = false;
 
     page.on("error", errorCaught);
     page.on("pageerror", errorCaught);
-    page.on("console", log => console[log._type](log._text));
 
     await page.setContent(`
     <html>
@@ -35,5 +44,14 @@ const debugging = false;
     else {
         console.log("Not closing the browser, you'll need to exit the process in your terminal manually");
     }
+    console.log(`${browserType} :+1:`);
   }
 })();
+
+process.on("unhandledRejection", (/** @type {any}*/ err) => {
+    if (err) {
+        console.error(err.stack || err.message);
+    }
+    process.exit(1);
+});
+
