Install playwright on demand #40722
Install playwright on demand #40722
Conversation
typescript-bot
added
Author: Team
For Uncommitted Bug
|
@orta have you ever seen the Playwright error the build failed with? It worked locally 🤔 |
|
I've not, will clone and look onw |
|
That worked locally for me too, digging around a bit in their issues seems to hint that maybe this is webkit specific - I've added some debugging flags to see what's going on there, but I'm not offended if we switch it to just ff and chromium in the browsers to test |
|
OK, I think that should be it - I think the in-process work for installing and setting up playwright didn't have things which would have been added to paths set up when it was being used (e.g. this error )
Give this is a .so issue, it's likely we Mac users didn't hit it |
|
Still no dice :/ |
|
Dropping safari did it, I'm alright with this |
| @@ -42,6 +42,9 @@ jobs: | |||
| - name: Linter | |||
| run: npm run lint:ci | |||
|
|
|||
| - name: Adding playwright | |||
| run: npm install --no-save --no-package-lock playwright | |||
There was a problem hiding this comment.
The reason I put this in browserIntegrationTest.js is so it would work locally without extra magic steps, but if you don’t care about running locally (I guess nobody would really want to do that), this is fine
🎭