Skip to content

Stop binding type predicate types twice #22210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 28, 2018
Merged

Stop binding type predicate types twice #22210

merged 1 commit into from
Feb 28, 2018

Conversation

weswigham
Copy link
Member

checkTypePredicate was doing the same work bindChildren ended up doing, which caused a container type in a predicate to get its nextContainer set to itself, causing an infinite loop elsewhere.

Fixes #22076

@weswigham weswigham requested review from mhegazy and a user February 27, 2018 21:38
@weswigham weswigham merged commit 7a31192 into microsoft:master Feb 28, 2018
@weswigham weswigham deleted the fix-typeguard-hang branch February 28, 2018 23:43
@ghost
Copy link

ghost commented Mar 1, 2018

👍

@microsoft microsoft locked and limited conversation to collaborators Jul 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mhegazy mhegazy mhegazy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@weswigham @mhegazy