Skip to content

Format unique symmbol string output with unique symbol and not typeof within checker #22247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 1, 2018

Conversation

weswigham
Copy link
Member

A tests was added between when #21403 was opened and merged that is affected by it (and is now breaking our build). The output seems fine.

Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know, it looks wrong, but I'd merge this and investigate why the code changed the baseline afterward.

@sandersn
Copy link
Member

sandersn commented Mar 1, 2018

Specifically, it's strange that in const x: string = Symbol(), the error is that 'typeof x' isn't assignable to 'string', since 'typeof x' is string — it's x's initializer that's not assignable to string.

@weswigham
Copy link
Member Author

@sandersn Changed typeToString to internally use unique symbol by default, since it's preferable there.

@weswigham weswigham changed the title Accept baseline update to symbol test Format unique symmbol string output with unique symbol and not typeof within checker Mar 1, 2018
@weswigham weswigham merged commit c12fc0d into microsoft:master Mar 1, 2018
@weswigham weswigham deleted the accept-recent-test-update branch March 1, 2018 01:56
@microsoft microsoft locked and limited conversation to collaborators Jul 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants