Use unknown serialization kind when type symbol isnt resolved #24332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a test for this in the transpileModule case. https://github.com/Microsoft/TypeScript/blob/master/src/harness/unittests/transpile.ts, we should make sure not to break this again. |
|
Also please port to release-2.9 |
mhegazy
approved these changes
May 22, 2018
weswigham
added a commit
to weswigham/TypeScript
that referenced
this pull request
May 22, 2018
…oft#24332) * Use unknown serialization kind when type symbol isnt resolved * Add test for the isolated modules case
mhegazy
added a commit
that referenced
this pull request
May 23, 2018
Use unknown serialization kind when type symbol isnt resolved (#24332)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way when a lib isn't present (eg, under
noLib), you can still get more accurate runtime type information.Our metadata emit will still differ between an
isolatedModulesandnoLibbuild and a normal one (the emit is type directed), but now they should have the same runtime functionality, at least.Fixes #16872