Use compare paths for comparing diagnostic paths, since the canonicalization of fileName and unitName differ #24340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ization of fileName and unitName differ
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a pair of RWC tests which were failing due to error count differences.
Potentially related real issue: Some source files in the affected compilations had rooted
fileNames, while others did not (glimmer is one of them, for reference) - given that's it's not aPath, this isn't disallowed, but does feel... odd. I believe it was the input file set (those passed via the tsconfig directly) which were unrooted, while the remainder were rooted.AFAIK with this change no more RWC tests should be failing due to harness bugs leftover from the vfs change and followups.