Fix empty files diagnostics reporting #26865
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26779
Fixes #26780
This PR aligns the diagnostic reporting for empty files with the behavior described in the handbook:
Specifically, the following 3 issues are addressed by this PR:
files
is empty, regardless of the value ofreferences
configFileParsingDiagnostics
are not being passed tocreateProgram
frombuildSingleProject
, meaning any parsing errors will go unreportedbuildAllProjects
, errors will go unreported if the for-loop iteration iscontinue
d because the errors are reported inbuildSingleProject
, which is at the end of the loop iterationUnit tests are included to account for the new behavior.