Ignore the directory watchers invoked in non polling watch mode with no relative file name information #27563
+4
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…no relative file name information Fixes #27326
ghost
reviewed
Oct 9, 2018
| const fileName = !isString(relativeFileName) | ||
| ? undefined! // TODO: GH#18217 | ||
| : getNormalizedAbsolutePath(relativeFileName, dirName); | ||
| if (!isString(relativeFileName)) { return; } |
There was a problem hiding this comment.
relativeFileName is typed as string, so either this code is a noop or the type of fsWatchDirectory is wrong.
ghost
approved these changes
Oct 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27326