For path completions, include extension as a kindModifier #28148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
force-pushed
the
pathCompletions_kindModifiers
branch
2 times, most recently
from
000f4d5 to
53dcb2a
Compare
ghost
force-pushed
the
pathCompletions_kindModifiers
branch
from
53dcb2a to
423be97
Compare
sheetalkamat
approved these changes
Oct 30, 2018
mjbvz
approved these changes
Oct 30, 2018
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #28116
This does not modify
name; instead it adds the extension intokindModifiers.Note for directories we don't include any extension, even if importing from the directory would resolve to e.g.
index.d.ts.(An alternate fix would be to add new choices of
kind, but since every file extension except.jsoncould be associated with either a script or a module, that would to a lot of combinations.)