Skip to content

Suggest adding to tsconfig after installing @types #28211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 30, 2018

Conversation

ajafff
Copy link
Contributor

@ajafff ajafff commented Oct 29, 2018

@sandersn sandersn merged commit 3356879 into microsoft:master Oct 30, 2018
@weswigham
Copy link
Member

Small improvement: Have both messages. If a types field exists in the options, use this message, otherwise, use the old one. If a user doesn't have an explicit types option, then they shouldn't need to do anything - they'll be included automatically.

@ajafff ajafff deleted the add-types-error branch October 30, 2018 19:38
@ajafff
Copy link
Contributor Author

ajafff commented Oct 30, 2018

@weswigham Sounds good to me. I'll open a follow-up PR.
Should there be a separate message if there is typeRoots in tsconfig?

@weswigham
Copy link
Member

Hm; If either of the other messages sound confusing in that context, then I guess so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants