Fixes export destructured variables reference #32007

sisisin · 2019-06-20T19:03:00Z

Fixes #31922

msftclas · 2019-06-20T19:03:13Z

All CLA requirements met.

ajafff · 2019-06-21T17:16:16Z

src/services/importTracker.ts

@@ -582,6 +582,12 @@ namespace ts.FindAllReferences {
            return p.name !== node ? undefined :
                p.parent.kind === SyntaxKind.CatchClause ? undefined : p.parent.parent.kind === SyntaxKind.VariableStatement ? p.parent.parent : undefined;
        }
+        else if (parent.parent && parent.parent.parent && parent.parent.parent.kind === SyntaxKind.VariableDeclaration) {


does this work for binding elements of arbitrary nesting?

export const {foo: [bar, {baz: bas}]} = someObj;

You probably want to use walkUpBindingElementsAndPatterns to get the VariableDeclaration of the BindingElement.

ajafff · 2019-06-21T17:18:41Z

src/testRunner/unittests/tsserver/getExportReferences.ts

+            path: "/mod.ts",
+            content: `export const value = 0;
+export const [valueA, valueB] = [0, 1];
+export const { valueC, valueD } = { valueC: 0, valueD: 1 };`,


can you add a test that renames the destructured property export const {foo: bar} = {foo: 2} to make sure this works as expected

sisisin · 2019-06-22T09:04:47Z

@ajafff Thank you for your review, I fixed them

rbuckton · 2019-06-28T19:20:28Z

src/testRunner/unittests/tsserver/getExportReferences.ts

+                ...override,
+            });
+
+        it("should get const variable decralation references", () => {


Suggested change

it("should get const variable decralation references", () => {

it("should get const variable declaration references", () => {

rbuckton · 2019-06-28T19:20:39Z

src/testRunner/unittests/tsserver/getExportReferences.ts

+            assert.deepEqual(response, expectResponse);
+        });
+
+        it("should get array destructuring decralation references", () => {


Suggested change

it("should get array destructuring decralation references", () => {

it("should get array destructuring declaration references", () => {

rbuckton · 2019-06-28T19:20:47Z

src/testRunner/unittests/tsserver/getExportReferences.ts

+            assert.deepEqual(response, expectResponse);
+        });
+
+        it("should get object destructuring decralation references", () => {


Suggested change

it("should get object destructuring decralation references", () => {

it("should get object destructuring declaration references", () => {

rbuckton · 2019-06-28T19:21:04Z

src/testRunner/unittests/tsserver/getExportReferences.ts

+            assert.deepEqual(response, expectResponse);
+        });
+
+        it("should get object decralation references that renames destructured property", () => {


Suggested change

it("should get object decralation references that renames destructured property", () => {

it("should get object declaration references that renames destructured property", () => {

rbuckton · 2019-06-28T19:21:14Z

src/testRunner/unittests/tsserver/getExportReferences.ts

+            assert.deepEqual(response, expectResponse);
+        });
+
+        it("should get nested object decralation references", () => {


Suggested change

it("should get nested object decralation references", () => {

it("should get nested object declaration references", () => {

sisisin · 2019-06-29T03:56:25Z

@rbuckton Thank you for your review, I fixed each commits to use rebase and edit.

rbuckton · 2019-08-05T19:00:12Z

Thanks for the contribution!

ajafff reviewed Jun 21, 2019

View reviewed changes

sisisin force-pushed the fix/destructured-variables-reference branch from 85771cf to 58ebc92 Compare June 22, 2019 08:46

sisisin force-pushed the fix/destructured-variables-reference branch 3 times, most recently from f2758db to 7c1dcb7 Compare June 26, 2019 14:40

RyanCavanaugh assigned rbuckton Jun 26, 2019

sisisin force-pushed the fix/destructured-variables-reference branch 3 times, most recently from f53d3e5 to 7953690 Compare June 28, 2019 13:14

rbuckton suggested changes Jun 28, 2019

View reviewed changes

sisisin force-pushed the fix/destructured-variables-reference branch from 7953690 to 55e8ba9 Compare June 29, 2019 03:52

sisisin force-pushed the fix/destructured-variables-reference branch 3 times, most recently from b2fcb06 to a1c5600 Compare July 3, 2019 15:03

sisisin force-pushed the fix/destructured-variables-reference branch 2 times, most recently from b9810ad to 1829d7b Compare July 11, 2019 15:57

sisisin force-pushed the fix/destructured-variables-reference branch 3 times, most recently from 878d7f5 to 9cecb5d Compare July 23, 2019 12:49

sisisin force-pushed the fix/destructured-variables-reference branch from 9cecb5d to 02294a7 Compare July 28, 2019 13:24

sisisin added 4 commits July 31, 2019 22:17

Add basic test for current behavior

5e2acb3

Fixes getting destructured variables references(microsoft#31922)

d59cb14

Add test case that renames destructured property

50d091a

Fixes missing nested object destrucuturing variable references

c04ef90

sisisin force-pushed the fix/destructured-variables-reference branch from 02294a7 to c04ef90 Compare July 31, 2019 13:24

rbuckton approved these changes Aug 5, 2019

View reviewed changes

rbuckton merged commit 33a6509 into microsoft:master Aug 5, 2019

sisisin deleted the fix/destructured-variables-reference branch August 7, 2019 15:08

sandersn mentioned this pull request Apr 30, 2021

Error in 'getExportAssignmentExport' during 'documentHighlights' #40082

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fixes export destructured variables reference #32007

Fixes export destructured variables reference #32007

Uh oh!

sisisin commented Jun 20, 2019

Uh oh!

msftclas commented Jun 20, 2019 •

edited

Loading

Uh oh!

ajafff Jun 21, 2019

Uh oh!

ajafff Jun 21, 2019

Uh oh!

sisisin commented Jun 22, 2019

Uh oh!

rbuckton Jun 28, 2019

Uh oh!

rbuckton Jun 28, 2019

Uh oh!

rbuckton Jun 28, 2019

Uh oh!

rbuckton Jun 28, 2019

Uh oh!

rbuckton Jun 28, 2019

Uh oh!

sisisin commented Jun 29, 2019

Uh oh!

rbuckton commented Aug 5, 2019

Uh oh!

Uh oh!

	it("should get const variable decralation references", () => {
	it("should get const variable declaration references", () => {

	it("should get array destructuring decralation references", () => {
	it("should get array destructuring declaration references", () => {

	it("should get object destructuring decralation references", () => {
	it("should get object destructuring declaration references", () => {

	it("should get object decralation references that renames destructured property", () => {
	it("should get object declaration references that renames destructured property", () => {

	it("should get nested object decralation references", () => {
	it("should get nested object declaration references", () => {

Fixes export destructured variables reference #32007

Fixes export destructured variables reference #32007

Uh oh!

Conversation

sisisin commented Jun 20, 2019

Uh oh!

msftclas commented Jun 20, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ajafff Jun 21, 2019

Choose a reason for hiding this comment

Uh oh!

ajafff Jun 21, 2019

Choose a reason for hiding this comment

Uh oh!

sisisin commented Jun 22, 2019

Uh oh!

rbuckton Jun 28, 2019

Choose a reason for hiding this comment

Uh oh!

rbuckton Jun 28, 2019

Choose a reason for hiding this comment

Uh oh!

rbuckton Jun 28, 2019

Choose a reason for hiding this comment

Uh oh!

rbuckton Jun 28, 2019

Choose a reason for hiding this comment

Uh oh!

rbuckton Jun 28, 2019

Choose a reason for hiding this comment

Uh oh!

sisisin commented Jun 29, 2019

Uh oh!

rbuckton commented Aug 5, 2019

Uh oh!

Uh oh!

msftclas commented Jun 20, 2019 •

edited

Loading