Check for parse errors in emitted JS #32009
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weswigham
commented
Jun 20, 2019
| ==== tests/cases/compiler/emitBOM.js (2 errors) ==== | ||
| // JS and d.ts output should have a BOM but not the sourcemap | ||
|
|
||
| !!! error TS1127: Invalid character. |
There was a problem hiding this comment.
@rbuckton you know what's up with the BOM here? I suspect it's actually an issue with the test harness not roundtripping the BOM correctly (maybe by not reading the output string with the correct encoding) and not a parse/emit bug, but I can't be sure.
weswigham
force-pushed
the
validate-JS-output
branch
from
efe76c0 to
3fc4d8b
Compare
|
I've merged this so we catch future failure-to-roundtrip bugs. I still don't know what's up with that BOM roundtrip, though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(When the input is error-free)
Fixes #2818
We have two tests which produce output JS with errors, which probably indicate bugs which need fixing.
There is a small cost to doing this validation, but not too much in aggregate since our parser is fast - only about 5% longer test times. (ofc, if a test is marked
@noEmit: truewe won't be doing it for that test - so tests where the emit doesn't matter should probably use that option more aggressively). And it already found some bugs, so clearly it is a good thing to check.