Remove secondary reference lookup implementation #32016
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/compiler/emitter.ts
Outdated
| @@ -725,7 +725,8 @@ namespace ts { | |||
| fileExists: f => host.fileExists(f), | |||
| directoryExists: host.directoryExists && (f => host.directoryExists!(f)), | |||
| useCaseSensitiveFileNames: () => host.useCaseSensitiveFileNames(), | |||
| getProgramBuildInfo: returnUndefined | |||
| getProgramBuildInfo: returnUndefined, | |||
| getSourceFileFromReference: returnUndefined, // TODO: Implement? | |||
There was a problem hiding this comment.
Should this be notImplemented. As this is just writing existing texts by updating prepend outputs.
There was a problem hiding this comment.
notImplemented causes a crash, since the method is actually used in the declaration emitter. Previously it would have relied on getSourceFile which is a returnUndefined, so using returnUndefined means the behavior hasn't changed.
There was a problem hiding this comment.
I see. Then it should be as you have returnUndefined since this emit is not going to recalculate the refs. Also since getSourceFile and getSourceFileByPath are returnUndefined as well. (I meant no TODO needed)
sheetalkamat
approved these changes
Jun 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15738
I didn't even know it was soft deprecated (or that another option existed) and was using it in the declaration emitter 🤷♂