-
Notifications
You must be signed in to change notification settings - Fork 12.9k
Simplify tuple destructuring logic #32178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@typescript-bot run dt |
Heya @ahejlsberg, I've started to run the extended test suite on this PR at 4c99084. You can monitor the build here. It should now contribute to this PR's status checks. |
Heya @ahejlsberg, I've started to run the parallelized Definitely Typed test suite on this PR at 4c99084. You can monitor the build here. It should now contribute to this PR's status checks. |
@typescript-bot run dt |
Heya @ahejlsberg, I've started to run the parallelized Definitely Typed test suite on this PR at 17153a6. You can monitor the build here. It should now contribute to this PR's status checks. |
Heya @ahejlsberg, I've started to run the extended test suite on this PR at 17153a6. You can monitor the build here. It should now contribute to this PR's status checks. |
DT and RWC test runs are clean (RWC difference is unrelated to this PR). |
This PR removes the general logic we had for padding array literals that are contextually typed by tuple types and isolates it to the one case where it is needed: parameter array binding elements with tuple type initializers of lesser arity than the array binding elements. It fixes the incorrect error that was reported in #32140 and picks up the better error messages that are reported by
getIndexedAccessType
.Fixes #32140.