Skip to content

🤖 User test baselines have changed #32483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

typescript-bot
Copy link
Collaborator

Please review the diff and merge if no changes are unexpected.
You can view the build log here.

cc @weswigham @sandersn @RyanCavanaugh

Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to merge, even though we're still having noise from numbers changing.

The new changes are

  1. An update to lodash
  2. Fixes to AsyncGenerator name resolution
  3. Better narrowing of element access.

@@ -382,8 +382,6 @@ node_modules/lodash/nthArg.js(28,26): error TS2345: Argument of type 'number | u
node_modules/lodash/omit.js(48,32): error TS2345: Argument of type 'number' is not assignable to parameter of type 'boolean'.
node_modules/lodash/orderBy.js(18,10): error TS1003: Identifier expected.
node_modules/lodash/orderBy.js(18,10): error TS8024: JSDoc '@param' tag has name '', but there is no parameter with that name.
node_modules/lodash/org.js(8,22): error TS2307: Cannot find module 'moment'.
node_modules/lodash/org.js(9,19): error TS2307: Cannot find module 'ncp'.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are new since yesterday

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pretty sure that's from a new version of lodash that published 14 hours ago; I don't see any module-resolution changes for us.

@sandersn
Copy link
Member

Also a change to @types/node.

@sandersn sandersn merged commit 90afd6d into microsoft:master Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants