Skip to content

Strip more kinds of timestamps and versions from dockerfile output #32519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jul 24, 2019

Conversation

weswigham
Copy link
Member

Also rewrite office-ui-fabric dockerfile to use new lerna build system.

This should get the timestampy output out of the azure-sdk build. Additionally, I've learned that while there wasn't a visible diff, office-ui-fabric was still failing, just way earlier - their build system swapped from using rush to learna, so I had to rewrite their Dockerfile (@JasonGore hope y'all gonna keep this new build system around for awhile XD). Likewise, vscode is currently failing early, during their build tool setup (rather than during their actual build) microsoft/vscode#77784 should get that back into a diff-reporting state.

…ewrite office-ui-fabric dockerfile to use new lerna build system
@weswigham weswigham requested a review from sandersn July 22, 2019 23:33
@weswigham
Copy link
Member Author

@typescript-bot user test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jul 22, 2019

Heya @weswigham, I've started to run the parallelized community code test suite on this PR at 05e9b0e. You can monitor the build here. It should now contribute to this PR's status checks.

@typescript-bot
Copy link
Collaborator

The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master.

@weswigham
Copy link
Member Author

@typescript-bot user test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jul 23, 2019

Heya @weswigham, I've started to run the parallelized community code test suite on this PR at 447e8c5. You can monitor the build here. It should now contribute to this PR's status checks.

@weswigham
Copy link
Member Author

@typescript-bot user test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jul 23, 2019

Heya @weswigham, I've started to run the parallelized community code test suite on this PR at 2bb0689. You can monitor the build here. It should now contribute to this PR's status checks.

@typescript-bot
Copy link
Collaborator

The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master.

@weswigham
Copy link
Member Author

@typescript-bot user test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jul 23, 2019

Heya @weswigham, I've started to run the parallelized community code test suite on this PR at a4fd2b3. You can monitor the build here. It should now contribute to this PR's status checks.

@typescript-bot
Copy link
Collaborator

The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master.

@weswigham
Copy link
Member Author

@typescript-bot user test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jul 23, 2019

Heya @weswigham, I've started to run the parallelized community code test suite on this PR at 54d3995. You can monitor the build here. It should now contribute to this PR's status checks.

@typescript-bot
Copy link
Collaborator

The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master.

@weswigham
Copy link
Member Author

@typescript-bot user test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jul 23, 2019

Heya @weswigham, I've started to run the parallelized community code test suite on this PR at 806b68d. You can monitor the build here. It should now contribute to this PR's status checks.

@typescript-bot
Copy link
Collaborator

The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master.

@weswigham
Copy link
Member Author

@typescript-bot user test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jul 23, 2019

Heya @weswigham, I've started to run the parallelized community code test suite on this PR at de01a92. You can monitor the build here. It should now contribute to this PR's status checks.

@weswigham
Copy link
Member Author

@typescript-bot user test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jul 23, 2019

Heya @weswigham, I've started to run the parallelized community code test suite on this PR at de01a92. You can monitor the build here. It should now contribute to this PR's status checks.

@weswigham
Copy link
Member Author

Apparently pipelines doesn't remove an old optional pipeline phase status indicators when it's not run in a subsequent build on the same commit 🤷‍♂

Anyways, these are all improvements now, imma merge em

@weswigham weswigham merged commit 40fd4ef into microsoft:master Jul 24, 2019
@weswigham weswigham deleted the dockerfile-more-filters branch July 24, 2019 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants