A merged interface with an inherited member should satisfy an abstract base class member #32539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t base class member
andrewbranch
commented
Jul 24, 2019
| if (baseDeclarationFlags & ModifierFlags.Private || derivedDeclarationFlags & ModifierFlags.Private) { | ||
| // either base or derived property is private - not override, skip it | ||
| continue; | ||
| } | ||
|
|
There was a problem hiding this comment.
This diff is really wonky if you don’t have “Hide whitespace changes” turned on.
|
@typescript-bot test this |
|
Heya @andrewbranch, I've started to run the extended test suite on this PR at 2ed1beb. You can monitor the build here. It should now contribute to this PR's status checks. |
sandersn
approved these changes
Jul 26, 2019
There was a problem hiding this comment.
I ... guess? It's weird that the implementing property needs to be identical to the abstract one instead of a subtype. That is, a normal subtype can say bar: 12 = 12 but the property from the merged interface has to be exactly the same type.
abstract is not a principled concept anyway, so a squishy gut check is about the best we can do.
sandersn
reviewed
Jul 26, 2019
weswigham
reviewed
Jul 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #31905
I kind of expected this to be fixed by a single insertion of
getMergedSymbolsomewhere, but it seems thatresolveObjectTypeMembers(which is called bygetPropertyOfType), when copying members from base types, just skips over any member with the same name as one that has already been resolved. In the linked issue / test case, theabstract BaseClassis closer thanIGetters, so its members get copied to the type, and then whenIGetters’ members get copied, it’s a no-op becausebaralready exists. So—is there an existing function that says “get me all the symbols that represent this property,” rather than just the closest?