Add error message for set accessor visibility issues #33683
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandersn
approved these changes
Sep 30, 2019
| ==== tests/cases/compiler/accessorDeclarationEmitVisibilityErrors.ts (2 errors) ==== | ||
| export class Q { | ||
| set bet(arg: DoesNotExist) {} | ||
| ~~~~~~~~~~~~ |
There was a problem hiding this comment.
names that don't exist create a "is using private name" errors? ok..
Yeah, unfortunately, the other two are there to cover the space of errors allowed by the type declarations for accessibility errors, but I don't think they're possible to ever trigger as, at least right now, a |
|
And now to wait for the next rwc diff on master, which'll include a ton of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the crash in
RWC.