Skip to content

Drop support for defunct Chakra host #33797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 4, 2020
Merged

Conversation

amcasey
Copy link
Member

@amcasey amcasey commented Oct 3, 2019

I'm experimenting with some host changes, so this seems like a good time to tidy up (rather than update) the Chakra host.

@amcasey amcasey requested a review from RyanCavanaugh October 3, 2019 22:51
@DanielRosenwasser
Copy link
Member

DanielRosenwasser commented Oct 4, 2019

I know it's an experiment, but don't merge this until post-RC please.

@amcasey amcasey closed this Oct 4, 2019
@amcasey amcasey reopened this Oct 4, 2019
@amcasey
Copy link
Member Author

amcasey commented Oct 4, 2019

@DanielRosenwasser It's not an experiment - this code is dead. It came up because I would have had to update it in my experiment. 😄 I'm happy to wait though.

@weswigham
Copy link
Member

The code is "dead" except we've heard of non-chakra consumers in, eg, the browser, providing the ChakraHost global to our spec in order to provide sys in the past, so removing it is still probably a break.

@amcasey
Copy link
Member Author

amcasey commented Oct 4, 2019

@weswigham I'll close this then?

@weswigham
Copy link
Member

I dunno - we might be able to remove it, we just have to be aware that it's a break.

@amcasey
Copy link
Member Author

amcasey commented Oct 23, 2019

@DanielRosenwasser @weswigham How do we feel about this?

@RyanCavanaugh
Copy link
Member

I'm pretty comfortable removing it at this point.

@mihailik FYI in case this is how you were shimming

@sandersn sandersn added the Housekeeping Housekeeping PRs label Feb 1, 2020
Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been out for several months now, so I think it's time to merge it.

@sandersn sandersn merged commit da8d3ef into microsoft:master Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Housekeeping Housekeeping PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants