Fix super method call chain, remove ? from method, improve vary-by #35013
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just noticed that #34951 may also fix the |
sandersn
approved these changes
Nov 12, 2019
src/compiler/binder.ts
Outdated
| @@ -3593,6 +3593,7 @@ namespace ts { | |||
| // overloads are TypeScript syntax. | |||
| if (node.decorators | |||
| || hasModifier(node, ModifierFlags.TypeScriptModifier) | |||
| || node.questionToken | |||
There was a problem hiding this comment.
Already fixed in @ajafff's PR, but we should keep your tests.
| @@ -0,0 +1,8 @@ | |||
| // @target: esnext,es2016 | |||
There was a problem hiding this comment.
isn't the ES5 emit interesting here too? I assume we could be putting a ? there too.
There was a problem hiding this comment.
ES5 emit changes the entire declaration to a function expression, so it wouldn't be caught by this change.
# Conflicts: # src/compiler/transformers/esnext.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes our emit for
super.method?.()andsuper["method"]?.(), as well as an incorrect emit forclass Base { method?() {} }.This also improves our ability to write compiler/conformance tests with multiple variations to now support:
*to include all possible values for an option (i.e.// @target: *)-or!prefix to exclude a value from an option (i.e.// @target: *,-es2015)// @strict: *). The full list is in src\testRunner\compilerRunner.tsFixes #34952At this point, this primarily just adds some additional tests and the improvements to vary-by.