Skip to content

Fixed unreported strict property initialization violations. #35891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 8, 2020
Merged

Fixed unreported strict property initialization violations. #35891

merged 1 commit into from
Jan 8, 2020

Conversation

dragomirtitian
Copy link
Contributor

Fixes #35884

mheiber
mheiber approved these changes Dec 28, 2019
View reviewed changes
Copy link
Contributor

@mheiber mheiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fwiw, the code and tests look good to me

I also did some manual testing, here's the (desired) error message from the language server:

error-property-has-no-initializer

@dragomirtitian
Copy link
Contributor Author

@DanielRosenwasser Any chance to get this merged before the beta goes out ?

@RyanCavanaugh RyanCavanaugh merged commit 3e4578c into microsoft:master Jan 8, 2020
@RyanCavanaugh
Copy link
Member

@dragomirtitian many thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mheiber mheiber mheiber approved these changes

@sheetalkamat sheetalkamat sheetalkamat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Definite assignment checks don't occur on private fields
4 participants
@dragomirtitian @RyanCavanaugh @mheiber @sheetalkamat