Skip to content

Fix children prop for react-jsx and react-jsxdev #40630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 18, 2020
Merged

Fix children prop for react-jsx and react-jsxdev #40630

merged 2 commits into from
Sep 18, 2020

Conversation

latin-1
Copy link
Contributor

@latin-1 latin-1 commented Sep 18, 2020

Fixes #40629

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Sep 18, 2020
@ghost
Copy link

ghost commented Sep 18, 2020 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

@orta orta requested a review from weswigham September 18, 2020 14:38
@weswigham
Copy link
Member

Thanks!

@weswigham weswigham merged commit f1ac8cd into microsoft:master Sep 18, 2020
@latin-1 latin-1 deleted the fix/react-jsx-children branch September 18, 2020 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weswigham weswigham weswigham approved these changes

Assignees
No one assigned
Labels
For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

react-jsx doesn't work well if an element has no props but only children.
3 participants
@latin-1 @weswigham @typescript-bot