Skip to content

Fix crash resolving ImportTypeNode in JSDoc #40838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 12, 2020

Conversation

andrewbranch
Copy link
Member

Fixes #40767

Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that condition used to be there and I deleted it at one point. This fixes this crash, but let's make sure that it doesn't break the user tests in some way.

@sandersn
Copy link
Member

sandersn commented Oct 9, 2020

@typescript-bot user test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Oct 9, 2020

Heya @sandersn, I've started to run the parallelized community code test suite on this PR at 19786df. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master.

@andrewbranch
Copy link
Member Author

According to the user tests, this PR is responsible for the rebranding of Office Fabric UI as Fluent UI.

@sandersn
Copy link
Member

sandersn commented Oct 9, 2020

Errr the Office Fabric cof Fluent UI tests are pretty broken right now, and the diff still contains unmerged diffs from master. Plus there's no JS in that project. I think we can take this as not causing any regressions.

@andrewbranch andrewbranch merged commit a09a714 into microsoft:master Oct 12, 2020
@andrewbranch andrewbranch deleted the bug/40767 branch October 12, 2020 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Milestone Bug PRs that fix a bug with a specific milestone
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Casting to a type generated from an @enum => Maximum call stack size exceeded
3 participants