Ensure whitespace jsx elements are not counted when determining if a jsx child is the only child #40839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…jsx child is the only child
typescript-bot
added
Author: Team
For Milestone Bug
nstepien
reviewed
Sep 30, 2020
Comment on lines
28
to
31
| console.log(jsx_runtime_1.jsxs("div", { children: jsx_runtime_1.jsx("div", {}, void 0) }, void 0)); | ||
| console.log(jsx_runtime_1.jsxs("div", { children: [jsx_runtime_1.jsx("div", {}, void 0), | ||
| jsx_runtime_1.jsx("div", {}, void 0)] }, void 0)); | ||
| console.log(jsx_runtime_1.jsxs("div", { children: [1, 2].map(function (i) { return jsx_runtime_1.jsx("div", { children: i }, i); }) }, void 0)); |
There was a problem hiding this comment.
Should the first and third examples use jsx instead of jsxs? Babel does it, so I'm curious.
There was a problem hiding this comment.
I've updated it to do so - we can always change back if that's not desirable for some reason.
RyanCavanaugh
approved these changes
Sep 30, 2020
sandersn
approved these changes
Sep 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #40774