Do not create packagejson imports and auto import provider in partial semantic server mode #40890
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… semantic server mode
sheetalkamat
requested review from
DanielRosenwasser,
andrewbranch and
RyanCavanaugh
typescript-bot
added
Author: Team
For Uncommitted Bug
| @@ -1622,6 +1622,7 @@ namespace ts.server { | |||
|
|
|||
| /*@internal*/ | |||
| getPackageJsonsVisibleToFile(fileName: string, rootDir?: string): readonly PackageJsonInfo[] { | |||
| if (this.projectService.serverMode !== LanguageServiceMode.Semantic) return emptyArray; | |||
There was a problem hiding this comment.
Slightly afraid of all the places that are going to need to be patched up in the future to check like this, but I guess that's programming
DanielRosenwasser
approved these changes
Oct 2, 2020
andrewbranch
approved these changes
Oct 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found this while looking into #39656 where it tried to read package.json file