#40763 Fixed: Bad error message when forgetting a comma in an array of templ… #40907
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of template strings
typescript-bot
added
the
For Uncommitted Bug
src/compiler/diagnosticMessages.json
Outdated
| @@ -3048,6 +3048,10 @@ | |||
| "category": "Error", | |||
| "code": 2795 | |||
| }, | |||
| "It is likely that you are missing a comma to separate these two template expressions. They form form a tagged template expression which is invalid.": { | |||
There was a problem hiding this comment.
Apart from the duplicate "form form", @sandersn what do you think?
Suggested change
| "It is likely that you are missing a comma to separate these two template expressions. They form form a tagged template expression which is invalid.": { | |
| "It is likely that you are missing a comma to separate these two template expressions. They form a tagged template expression which cannot be invoked.": { |
There was a problem hiding this comment.
Yes, that sounds reasonable to me.
| @@ -27872,6 +27872,12 @@ namespace ts { | |||
| return resolveUntypedCall(node); | |||
| } | |||
|
|
|||
| if (isArrayLiteralExpression(node.parent)) { | |||
There was a problem hiding this comment.
I would move this into the !callSignatures.length check because there is technically a way to make this work in the type system.
interface String {
(...args: any[]): any;
}
// should not error.
let x = [
`hello`
`world`
];
sandersn
approved these changes
Oct 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the error message mentioned by @DanielRosenwasser as a part of grace hopper OSD.
Fixes #40763